Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vars): add spacing variables from figma #155

Merged
merged 2 commits into from
Mar 9, 2023
Merged

feat(vars): add spacing variables from figma #155

merged 2 commits into from
Mar 9, 2023

Conversation

nathanjamal
Copy link
Collaborator

@nathanjamal nathanjamal commented Mar 7, 2023 •
edited
Loading

Pull Request

Description

added correct spacing variables from figma and replace all usages of old gap in docs

HEYUI-257

Screenshot 2023-03-07 at 16 27 34

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

@nathanjamal
feat(vars): add spacing variables from figma
dc75d66 
added correct spacing variables from figma and replace all usages of old gap in docs
HEYUI-257
@auto-assign auto-assign bot requested a review from esraltintas March 7, 2023 16:07
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Compiled a new version demo.

@coveralls
Copy link

coveralls commented Mar 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4356378584

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.467%
Totals Coverage Status
Change from base Build 4346789629: 0.0%
Covered Lines: 1082
Relevant Lines: 1101
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Mar 7, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 97.7% 1188/1216
🟢 Branches 85.53% 266/311
🟢 Functions 94.79% 91/96
🟢 Lines 98.27% 1082/1101

Test suite run success

273 tests passing in 41 suites.

Report generated by 🧪jest coverage report action from 5c40b20

@nathanjamal
refactor(vars): remove unused file
5c40b20 
remove unused file and add comment

HEYUI-257
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Compiled a new version demo.

@esraltintas esraltintas merged commit 99885d2 into main Mar 9, 2023
@esraltintas esraltintas deleted the HEYUI-257 branch March 9, 2023 12:33
supcar pushed a commit that referenced this pull request Mar 9, 2023
@semantic-release-bot
chore(release): 4.5.0 [skip ci]
146ce3c 
# [4.5.0](v4.4.1...v4.5.0) (2023-03-09)

### Bug Fixes

* **accordion:** accordion updates from design review ([#158](#158)) ([5f37ad7](5f37ad7))

### Features

* **vars:** add spacing variables from figma ([#155](#155)) ([99885d2](99885d2))
@supcar
Copy link
Collaborator

supcar commented Mar 9, 2023

🎉 This PR is included in version 4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@supcar supcar added the released label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esraltintas esraltintas esraltintas approved these changes

Assignees

@nathanjamal nathanjamal

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nathanjamal @coveralls @supcar @esraltintas