Initial PR #1
Merged
Initial PR #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwagdi
previously approved these changes
Apr 4, 2022
mwagdi
reviewed
Apr 4, 2022
There was a problem hiding this comment.
@derek-heycar I get Failed to resolve a react-scripts package while attempting to start storybook
mwagdi
approved these changes
Apr 4, 2022
hey-igor
approved these changes
Apr 4, 2022
packages/vars/src/typography.css
Outdated
| @@ -0,0 +1,56 @@ | |||
| :root { | |||
| --font-family-system: Objektiv, sans-serif, 'Helvetica Neue', Helvetica, Arial; | |||
| --font-family-styrene: Objektiv, sans-serif, 'Helvetica Neue', Helvetica, | |||
There was a problem hiding this comment.
Thanks for noticing that. But actually, the css-variables package has not been finished yet. I thought to use it as an intermediate variable for the font, but I've checked, and it's not needed now.
I'll replace it.
ggonchar
reviewed
Apr 4, 2022
| test: cssRegex, | ||
| }), | ||
|
|
||
| // new OptimizeCSSAssetsPlugin({ |
There was a problem hiding this comment.
Should we rather remove those lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR