Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature heycar uikit 63 typography component #34

Merged
merged 39 commits into from
Jun 15, 2022

Conversation

derek-heycar
Copy link
Contributor

@derek-heycar derek-heycar commented Jun 13, 2022

Pull Request

Description

The Typography component is used to display any types of text present on the heycar-uikit design system.

In the design prototypes, when clicking on text, you will find a variant name like h1, subheading2, body4. That's all that you need to get your text component ready.
Each variant contains already the expected font size, font weight, letter spacing, line height, and text transform.

Screenshot 2022-06-13 at 17 32 33

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:screenshots - to run snapshot tests

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

derek-heycar and others added 30 commits April 4, 2022 14:04
* initial project config

* init storybook

* building scripts

* docs

* first packages vars themes button

* rollup building tools

* project types

* feat: add heycar font to storybook

* feat: adjust colors according to branding

* feat: adjust colors in sidebar and links

* feat: style action button

* feat: remove Docs tab from guidelines

* feat: override body styles

* feat: override button font

* feat: style code snippet

* feat: add grey colors to vars

* feat: add error colors to vars

* feat: replace hex colors with vars

* refactor: use camel case for filename

Co-authored-by: Oleksandr Zhukov <[email protected]>
Implementing packages building

Implementing the rollup building for each independence component and core package.

Building packages

$ npm i
$ npm run build
Building result

Build results in the dist folder on the root and in the folder dist in each package in the packages folder.

Build format support

es5 - ES5 build with CommonJS modules
modern - ES2020 build with esm modules.
cssm - ES5 build with commonjs modules. CSS modules are supplied as is, not compiled.
esm - ES5 build with esm modules.
Add build actions

* test jest checking
* lint checking
* build packages
* add default reviewer for PR's
* fix: fix typo

* feat: init Table component

* fix fix type issue on Status

* feat: style table

* feat: add colors to vars

* feat: style status component

* feat: adjust story content

* refactor: nest table styles
* build Storybook command script
* build script for preparing Storybook files
* gitHub bot adding the link on the Storybook page
* feat: create TabContainer

* feat: add TabContainer to button story

* feat: style TabContainer

* style: add new lines

* refactor: extractb types

* style: use react fragment

* refactor: define button attributes
* feat: add PR template

* feat: add bug report template

* feat: add feature request template

* feat: add header to issue templates

* style: add new lines

* feat: init CONTRIBUTING

* remove ticket from PR template

* Revert "feat: init CONTRIBUTING"

This reverts commit 47045d3.

* feat: add more to checklist

* fix: fix typos and missing details

* feat: add testing steps in PR template
* The Shell scripts for build releases packages
* Added the GitHub workflows actions, make releases by the merge to the main branch
* Added the semantic-release packages as dev-dependencies.
* Added helper scripts to the package.json file
* remove workflow for main remove `pull_request` trigger
* Added utils and helpers for the screenshot tests for comparing images
* Documentation for the run screenshot tests
* Added `github actions` for run screenshot test on each PR to develop branch
* Added `git-lfs` hooks for the contained screenshot images
* feat(theme): create default theme

BREAKING CHANGE: new color names based on design system
@auto-assign auto-assign bot requested review from hey-igor and mwagdi June 13, 2022 15:32
@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented Jun 13, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 64/64
🟡 Branches 77.78% 14/18
🟢 Functions 100% 4/4
🟢 Lines 100% 55/55
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Button.tsx
100% 78.57% 100% 100%
🟢
... / ButtonIcon.tsx
100% 100% 100% 100%
🟢
... / ButtonLoader.tsx
100% 100% 100% 100%
🟢
... / Typography.tsx
100% 75% 100% 100%
🟢
... / Typography.constants.ts
100% 100% 100% 100%

Test suite run success

31 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 8810914

@derek-heycar derek-heycar requested review from hcafaq and removed request for hey-igor June 13, 2022 15:47
@coveralls
Copy link

coveralls commented Jun 13, 2022

Pull Request Test Coverage Report for Build 2502225425

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 94.521%

Totals Coverage Status
Change from base Build 2460670665: 0.2%
Covered Lines: 55
Relevant Lines: 55

💛 - Coveralls

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

Compiled a new version demo.

Copy link
Contributor

@hcafaq hcafaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works fine on my local and the code looks good

image

@derek-heycar derek-heycar merged commit 48aa261 into main Jun 15, 2022
@derek-heycar derek-heycar deleted the feature-heycar-uikit-63-typography-component branch June 15, 2022 15:59
derek-heycar pushed a commit that referenced this pull request Jun 15, 2022
# [1.1.0](v1.0.0...v1.1.0) (2022-06-15)

### Features

* **typography:** typography component ([#34](#34)) ([48aa261](48aa261))
@derek-heycar
Copy link
Contributor Author

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants