Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): reset subnav state on page change + position fixed #219

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

nathanjamal
Copy link
Collaborator

reset subnav state on page change. Plus added a hook into the burger menu toggle event so parent app can do things like lock the page scroll when nav is open. Also changed back to position fixed for more stable sticky behaviour

BREAKING CHANGE: Header changed from position sticky to position fixed

HEYUI-365

Pull Request

Description

Describe your changes (or add ticket description) and add relevant screenshots

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

reset subnav state on page change. Plus added a hook into the burger menu toggle event so parent app
can do things like lock the page scroll when nav is open. Also changed back to position fixed for
more stable sticky behaviour

BREAKING CHANGE: Header changed from position sticky to position fixed

HEYUI-365
@nathanjamal nathanjamal self-assigned this Jun 12, 2023
@auto-assign auto-assign bot requested a review from esraltintas June 12, 2023 14:53
@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Pull Request Test Coverage Report for Build 5246051666

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 92.485%

Totals Coverage Status
Change from base Build 5212697865: 0.3%
Covered Lines: 1675
Relevant Lines: 1737

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 96.2% 1874/1948
🟢 Branches 81.86% 528/645
🟢 Functions
83.67% (+1.2% 🔼)
164/196
🟢 Lines 96.43% 1675/1737

Test suite run success

402 tests passing in 56 suites.

Report generated by 🧪jest coverage report action from ae6daa4

@github-actions
Copy link

Compiled a new version demo.

@nathanjamal nathanjamal merged commit 0430432 into main Jun 14, 2023
@nathanjamal nathanjamal deleted the HEYUI-365 branch June 14, 2023 14:24
supcar pushed a commit that referenced this pull request Jun 14, 2023
# [9.0.0](v8.8.0...v9.0.0) (2023-06-14)

### Bug Fixes

* **header:** reset subnav state on page change + position fixed ([#219](#219)) ([0430432](0430432))

### BREAKING CHANGES

* **header:** Header changed from position sticky to position fixed

HEYUI-365

* update docs
@supcar
Copy link
Collaborator

supcar commented Jun 14, 2023

🎉 This PR is included in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5246051666

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 92.485%

Totals Coverage Status
Change from base Build 5212697865: 0.3%
Covered Lines: 1675
Relevant Lines: 1737

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants