feat(app-store-button): app store badges for iOS and Android #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configurable app buttons HEYUI-324
|
Compiled a new version demo. |
Pull Request Test Coverage Report for Build 5066982031
💛 - Coveralls |
Coverage report
Show new covered files 🐣
Test suite run success375 tests passing in 51 suites. Report generated by 🧪jest coverage report action from a816f48 |
|
Compiled a new version demo. |
rollup needed a plugin to handle images HEYUI-324
|
Compiled a new version demo. |
added app store button component HEYUI-324
nathanjamal
commented
May 23, 2023
| @@ -17,6 +17,8 @@ module.exports = { | |||
| moduleNameMapper: { | |||
| '@heycar-uikit/(.*)$': '<rootDir>/packages/$1/src', | |||
| '\\.css$': 'identity-obj-proxy', | |||
| '\\.(jpg|ico|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$': | |||
There was a problem hiding this comment.
mock images and vids for jest
remove unused vite references HEYUI-324
nathanjamal
commented
May 23, 2023
| @@ -1,5 +1,6 @@ | |||
| import path from 'path'; | |||
|
|
|||
| import image from '@rollup/plugin-image'; | |||
There was a problem hiding this comment.
plugin to allow rollup to handle images
nathanjamal
commented
May 23, 2023
| @@ -6,7 +6,6 @@ | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "build": "./bin/build.sh", | |||
| "build:vite": "vite build", | |||
There was a problem hiding this comment.
removed all references to Vite. This is test code from Nathan Nelson that isnt being used
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
esraltintas
approved these changes
May 24, 2023
|
🎉 This PR is included in version 8.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
configurable app buttons
HEYUI-324
Screen.Recording.2023-05-24.at.10.13.39.mov
Type of change
How do I test this
Checklist
Did you remember to take care of the following?
npm i– for new NPM dependencies.npm run lint- to check for linting issuesnpm run test- to run unit testsnpm run test:sh:docker- to run screenshot tests, detail instructionNew Feature / Bug Fix
Thanks for contributing!