-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle tree-shakeable angular client case #973
Conversation
Run & review this pull request in StackBlitz Codeflow. |
🦋 Changeset detectedLatest commit: 8f7a14f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a nice fix, thank you @jacobinu. Can you please add a changelog entry and update snapshots so it will pass tests?
128c3d4
to
b201278
Compare
b201278
to
8f7a14f
Compare
Done, hopefully formatted the changelog correctly. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
==========================================
- Coverage 76.64% 76.42% -0.22%
==========================================
Files 89 89
Lines 10868 10911 +43
Branches 1110 1111 +1
==========================================
+ Hits 8330 8339 +9
- Misses 2531 2565 +34
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
commit:
|
Fixes #638
Example configuration:
npx @hey-api/openapi-ts -c angular -i .\api\swaggger\auth-swagger.json -o .\api\generated\auth\
Use anonymous functions instead of arrow functions in the generated
services.ts
code. This allow callers to bindthis
to pass Angular'sHttpClient
.