Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow clients to throw on error #830

Merged
merged 4 commits into from
Aug 1, 2024
Merged

feat: allow clients to throw on error #830

merged 4 commits into from
Aug 1, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Jul 28, 2024

Closes #680
Closes #648

Copy link

stackblitz bot commented Jul 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Jul 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 5:01pm

Copy link

changeset-bot bot commented Jul 28, 2024

🦋 Changeset detected

Latest commit: 323d0a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@hey-api/client-fetch Minor
@hey-api/docs Patch
@hey-api/client-axios Minor
@hey-api/openapi-ts Patch
@example/openapi-ts-fetch Patch
@example/openapi-ts-axios Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 49.65986% with 74 lines in your changes missing coverage. Please review.

Project coverage is 72.96%. Comparing base (6c0add7) to head (323d0a0).

Files Patch % Lines
packages/openapi-ts/src/generate/services.ts 33.33% 24 Missing ⚠️
packages/openapi-ts/src/compiler/transform.ts 4.76% 20 Missing ⚠️
packages/openapi-ts/src/compiler/types.ts 41.17% 10 Missing ⚠️
packages/openapi-ts/src/compiler/utils.ts 25.00% 6 Missing ⚠️
packages/openapi-ts/src/compiler/classes.ts 20.00% 4 Missing ⚠️
packages/openapi-ts/src/compiler/module.ts 91.66% 3 Missing ⚠️
packages/openapi-ts/src/generate/transformers.ts 0.00% 3 Missing ⚠️
packages/openapi-ts/src/generate/plugins.ts 0.00% 2 Missing ⚠️
packages/openapi-ts/src/generate/types.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
+ Coverage   72.83%   72.96%   +0.13%     
==========================================
  Files          84       83       -1     
  Lines        8959     8999      +40     
  Branches      797      803       +6     
==========================================
+ Hits         6525     6566      +41     
+ Misses       2430     2429       -1     
  Partials        4        4              
Flag Coverage Δ
unittests 72.96% <49.65%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit c980dbf into main Aug 1, 2024
15 of 16 checks passed
@mrlubos mrlubos deleted the feat/throw-on-error branch August 1, 2024 17:08
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant