Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make config option required #828

Merged
merged 1 commit into from
Jul 28, 2024
Merged

feat: make config option required #828

merged 1 commit into from
Jul 28, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Jul 28, 2024

No description provided.

Copy link

stackblitz bot commented Jul 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jul 28, 2024

🦋 Changeset detected

Latest commit: 82a4696

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hey-api/openapi-ts Minor
@hey-api/docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 4:36am

@mrlubos mrlubos marked this pull request as ready for review July 28, 2024 04:36
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.26%. Comparing base (a66d739) to head (82a4696).

Files Patch % Lines
packages/openapi-ts/src/index.ts 50.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   73.38%   73.26%   -0.13%     
==========================================
  Files          84       84              
  Lines        8875     8883       +8     
  Branches      798      796       -2     
==========================================
- Hits         6513     6508       -5     
- Misses       2358     2371      +13     
  Partials        4        4              
Flag Coverage Δ
unittests 73.26% <50.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 1e400ad into main Jul 28, 2024
14 of 16 checks passed
@mrlubos mrlubos deleted the docs/migration-0-51-0 branch July 28, 2024 04:43
@github-actions github-actions bot mentioned this pull request Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant