-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add config to generate file extensions for module resolution no… #644
base: main
Are you sure you want to change the base?
feat: add config to generate file extensions for module resolution no… #644
Conversation
Run & review this pull request in StackBlitz Codeflow. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey, can you resolve the conflicts please? This doesn't seem to work based on tsconfig, am I right? If so, why include changes to tsconfig in the diff? |
@@ -1,6 +1,6 @@ | |||
import path from 'node:path' | |||
|
|||
import { EOL } from 'os' | |||
import {EOL} from 'os' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change made by a formatter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
yes, I do want to create a failing test based on the new config overrides. Will resolve conflicts. |
@mrlubos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this diff?
This doesn't seem to work based on tsconfig, am I right? If so, why include changes to tsconfig in the diff? |
Any updates on this issue? Recently, I started a new project with ESM and ran into this problem. |
@martinssonj |
…de16+