Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axios client #613

Merged
merged 12 commits into from
Jul 21, 2024
Merged

Axios client #613

merged 12 commits into from
Jul 21, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented May 23, 2024

No description provided.

Copy link

stackblitz bot commented May 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2024 8:46pm

Copy link

changeset-bot bot commented May 23, 2024

🦋 Changeset detected

Latest commit: b0e8a98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@hey-api/client-fetch Patch
@hey-api/client-axios Minor
@hey-api/openapi-ts Minor
@hey-api/docs Patch
@example/openapi-ts-fetch Patch
@example/openapi-ts-axios Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

let axiosRequestConfig: AxiosRequestConfig = {
...opts,
url,
}

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (90% of all statements in the enclosing function have an explicit semicolon).
const body = getRequestBody(options);
const headers = await getHeaders(config, options);
for (const fn of interceptors.request._fns) {
axiosRequestConfig = await fn(axiosRequestConfig, opts)

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (90% of all statements in the enclosing function have an explicit semicolon).
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.34%. Comparing base (e7bd6ae) to head (b0e8a98).

Files Patch % Lines
packages/openapi-ts/src/generate/services.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #613   +/-   ##
=======================================
  Coverage   73.34%   73.34%           
=======================================
  Files          81       81           
  Lines        8557     8557           
  Branches      792      792           
=======================================
  Hits         6276     6276           
  Misses       2277     2277           
  Partials        4        4           
Flag Coverage Δ
unittests 73.34% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos marked this pull request as ready for review July 21, 2024 20:36
@mrlubos mrlubos merged commit b642d4c into main Jul 21, 2024
16 checks passed
@mrlubos mrlubos deleted the fix/client-beta-2 branch July 21, 2024 20:53
@github-actions github-actions bot mentioned this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant