Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not export inline enums #508

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

jordanshatford
Copy link
Collaborator

This is causing issues in builds. These types do not need to be exported as they are inlined in other types.

@jordanshatford jordanshatford requested a review from mrlubos April 28, 2024 23:41
Copy link

stackblitz bot commented Apr 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Apr 28, 2024

🦋 Changeset detected

Latest commit: 8fb464e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2024 11:41pm

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 78.99%. Comparing base (13ebddc) to head (8fb464e).

Files Patch % Lines
packages/openapi-ts/src/utils/write/types.ts 9.09% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   79.11%   78.99%   -0.12%     
==========================================
  Files          74       74              
  Lines        6109     6118       +9     
  Branches      617      617              
==========================================
  Hits         4833     4833              
- Misses       1273     1282       +9     
  Partials        3        3              
Flag Coverage Δ
unittests 78.99% <9.09%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanshatford jordanshatford merged commit e3b9876 into main Apr 29, 2024
14 of 16 checks passed
@jordanshatford jordanshatford deleted the fix/do-not-export-unless-needed branch April 29, 2024 08:02
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants