Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle indexed access checks #1468

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Dec 19, 2024

Closes #1388

Copy link

stackblitz bot commented Dec 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos mrlubos marked this pull request as ready for review December 19, 2024 15:45
Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 20d7497

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@hey-api/client-axios Patch
@hey-api/client-fetch Patch
@hey-api/openapi-ts Patch
@example/openapi-ts-axios Patch
@example/openapi-ts-fastify Patch
@example/openapi-ts-fetch Patch
@example/openapi-ts-tanstack-angular-query-experimental Patch
@example/openapi-ts-tanstack-react-query Patch
@example/openapi-ts-tanstack-svelte-query Patch
@example/openapi-ts-tanstack-vue-query Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 3:46pm

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 49 lines in your changes missing coverage. Please review.

Project coverage is 63.41%. Comparing base (6dfbd49) to head (20d7497).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/ir/parameter.ts 11.11% 8 Missing ⚠️
...kages/openapi-ts/src/openApi/3.0.x/parser/index.ts 0.00% 6 Missing ⚠️
...api-ts/src/plugins/@hey-api/transformers/plugin.ts 0.00% 6 Missing ⚠️
...ages/openapi-ts/src/openApi/3.0.x/parser/schema.ts 0.00% 5 Missing ⚠️
...ages/openapi-ts/src/plugins/@hey-api/sdk/plugin.ts 16.66% 5 Missing ⚠️
.../openapi-ts/src/plugins/@hey-api/schemas/plugin.ts 0.00% 4 Missing ⚠️
.../src/plugins/@tanstack/query-core/plugin-legacy.ts 0.00% 4 Missing ⚠️
packages/openapi-ts/src/compiler/types.ts 0.00% 2 Missing ⚠️
...kages/openapi-ts/src/openApi/3.1.x/parser/index.ts 66.66% 2 Missing ⚠️
packages/openapi-ts/src/plugins/zod/plugin.ts 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1468      +/-   ##
==========================================
- Coverage   63.42%   63.41%   -0.02%     
==========================================
  Files         143      143              
  Lines       22261    22270       +9     
  Branches     1846     1846              
==========================================
+ Hits        14119    14122       +3     
- Misses       8136     8142       +6     
  Partials        6        6              
Flag Coverage Δ
unittests 63.41% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Dec 19, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@hey-api/client-axios@1468
npm i https://pkg.pr.new/@hey-api/openapi-ts@1468
npm i https://pkg.pr.new/@hey-api/client-fetch@1468

commit: 20d7497

@mrlubos mrlubos merged commit ac442f0 into main Dec 19, 2024
15 of 17 checks passed
@mrlubos mrlubos deleted the fix/no-unchecked-indexed-access branch December 19, 2024 15:55
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant