Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow arbitrary object properties when additionalProperties is undefined #1390

Merged

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Dec 4, 2024

Closes #1381

Copy link

stackblitz bot commented Dec 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 11:24pm

@mrlubos mrlubos marked this pull request as ready for review December 4, 2024 23:24
Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 8388c47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (7ee3960) to head (8388c47).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ages/openapi-ts/src/openApi/3.0.x/parser/schema.ts 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1390      +/-   ##
==========================================
- Coverage   64.31%   64.31%   -0.01%     
==========================================
  Files         140      140              
  Lines       21773    21781       +8     
  Branches     1834     1835       +1     
==========================================
+ Hits        14004    14008       +4     
- Misses       7763     7767       +4     
  Partials        6        6              
Flag Coverage Δ
unittests 64.31% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 311b863 into main Dec 4, 2024
14 of 16 checks passed
@mrlubos mrlubos deleted the fix/experimental-parser-additional-properties-undefined branch December 4, 2024 23:32
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type generation not done properly
1 participant