Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle non-exploded array query parameters #1265

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Nov 9, 2024

Closes #1255

Copy link

stackblitz bot commented Nov 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Nov 9, 2024

🦋 Changeset detected

Latest commit: 691cdc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review November 9, 2024 21:43
Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 9:43pm

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 59.39394% with 67 lines in your changes missing coverage. Please review.

Project coverage is 67.63%. Comparing base (37970e0) to head (691cdc2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/openapi-ts/src/openApi/3.0.x/parser/parameter.ts 26.31% 42 Missing ⚠️
...openapi-ts/src/plugins/@hey-api/services/plugin.ts 25.00% 24 Missing ⚠️
...s/openapi-ts/src/openApi/3.1.x/parser/parameter.ts 98.24% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1265      +/-   ##
==========================================
- Coverage   67.71%   67.63%   -0.09%     
==========================================
  Files         132      132              
  Lines       19528    19682     +154     
  Branches     1755     1773      +18     
==========================================
+ Hits        13224    13311      +87     
- Misses       6300     6367      +67     
  Partials        4        4              
Flag Coverage Δ
unittests 67.63% <59.39%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit f31d4e2 into main Nov 9, 2024
14 of 16 checks passed
@mrlubos mrlubos deleted the fix/parameters-explode-false branch November 9, 2024 21:53
@github-actions github-actions bot mentioned this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explode option in openapi schema is not being respected
1 participant