Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite date type transform to new parser #1184

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Oct 22, 2024

No description provided.

Copy link

stackblitz bot commented Oct 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos mrlubos marked this pull request as ready for review October 22, 2024 12:47
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 0:47am

Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: b1b6f85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 82.84389% with 111 lines in your changes missing coverage. Please review.

Project coverage is 75.01%. Comparing base (55d5715) to head (b1b6f85).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...api-ts/src/plugins/@hey-api/transformers/plugin.ts 75.07% 85 Missing ⚠️
...napi-ts/src/plugins/@tanstack/query-core/plugin.ts 0.00% 12 Missing ⚠️
packages/openapi-ts/src/ir/operation.ts 94.48% 8 Missing ⚠️
...napi-ts/src/plugins/@hey-api/transformers/index.ts 76.92% 3 Missing ⚠️
...es/openapi-ts/src/plugins/@hey-api/types/plugin.ts 95.91% 2 Missing ⚠️
packages/openapi-ts/src/ir/schema.ts 98.48% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
+ Coverage   74.98%   75.01%   +0.02%     
==========================================
  Files         123      127       +4     
  Lines       17205    17533     +328     
  Branches     1706     1705       -1     
==========================================
+ Hits        12902    13152     +250     
- Misses       4300     4378      +78     
  Partials        3        3              
Flag Coverage Δ
unittests 75.01% <82.84%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Oct 22, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@hey-api/client-axios@1184
pnpm add https://pkg.pr.new/@hey-api/client-fetch@1184
pnpm add https://pkg.pr.new/@hey-api/openapi-ts@1184

commit: b1b6f85

@mrlubos mrlubos merged commit 2834ccf into main Oct 22, 2024
17 checks passed
@mrlubos mrlubos deleted the feat/parser-plugin-transformers branch October 22, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant