fix: assign default fetch implementation dynamically to work with msw

hey-api · Dec 4, 2024 · fa8b0f1 · fa8b0f1
1 parent 311b863
commit fa8b0f1
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/new-spies-crash.md b/.changeset/new-spies-crash.md
@@ -0,0 +1,5 @@
+---
+'@hey-api/client-fetch': patch
+---
+
+fix: assign default fetch implementation dynamically to work with msw
diff --git a/packages/client-fetch/src/index.ts b/packages/client-fetch/src/index.ts
@@ -51,6 +51,7 @@ export const createClient = (config: Config = {}): Client => {
     const opts: RequestOptions = {
       ..._config,
       ...options,
+      fetch: options.fetch ?? _config.fetch ?? globalThis.fetch,
       headers: mergeHeaders(_config.headers, options.headers),
     };
     if (opts.body && opts.bodySerializer) {

diff --git a/packages/client-fetch/src/utils.ts b/packages/client-fetch/src/utils.ts
@@ -578,7 +578,6 @@ const defaultHeaders = {
 export const createConfig = (override: Config = {}): Config => ({
   ...jsonBodySerializer,
   baseUrl: '',
-  fetch: globalThis.fetch,
   headers: defaultHeaders,
   parseAs: 'auto',
   querySerializer: defaultQuerySerializer,

diff --git a/...-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle/client/index.ts.snap b/...-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle/client/index.ts.snap
@@ -51,6 +51,7 @@ export const createClient = (config: Config = {}): Client => {
     const opts: RequestOptions = {
       ..._config,
       ...options,
+      fetch: options.fetch ?? _config.fetch ?? globalThis.fetch,
       headers: mergeHeaders(_config.headers, options.headers),
     };
     if (opts.body && opts.bodySerializer) {

diff --git a/...-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle/client/utils.ts.snap b/...-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle/client/utils.ts.snap
@@ -578,7 +578,6 @@ const defaultHeaders = {
 export const createConfig = (override: Config = {}): Config => ({
   ...jsonBodySerializer,
   baseUrl: '',
-  fetch: globalThis.fetch,
   headers: defaultHeaders,
   parseAs: 'auto',
   querySerializer: defaultQuerySerializer,

diff --git a/..._snapshots__/test/generated/v3-hey-api-client-fetch-bundle_transform/client/index.ts.snap b/..._snapshots__/test/generated/v3-hey-api-client-fetch-bundle_transform/client/index.ts.snap
@@ -51,6 +51,7 @@ export const createClient = (config: Config = {}): Client => {
     const opts: RequestOptions = {
       ..._config,
       ...options,
+      fetch: options.fetch ?? _config.fetch ?? globalThis.fetch,
       headers: mergeHeaders(_config.headers, options.headers),
     };
     if (opts.body && opts.bodySerializer) {

diff --git a/..._snapshots__/test/generated/v3-hey-api-client-fetch-bundle_transform/client/utils.ts.snap b/..._snapshots__/test/generated/v3-hey-api-client-fetch-bundle_transform/client/utils.ts.snap
@@ -578,7 +578,6 @@ const defaultHeaders = {
 export const createConfig = (override: Config = {}): Config => ({
   ...jsonBodySerializer,
   baseUrl: '',
-  fetch: globalThis.fetch,
   headers: defaultHeaders,
   parseAs: 'auto',
   querySerializer: defaultQuerySerializer,