Add NSWindow and NSWindowDelegate methods #25
Conversation
| @@ -1911,14 +1911,27 @@ fn generateAppKit(generator: anytype) !void { | |||
| [2][]const u8{ "NSWindow", "isVisible" }, | |||
| [2][]const u8{ "NSWindow", "setIsVisible" }, | |||
| [2][]const u8{ "NSWindow", "makeKeyAndOrderFront" }, | |||
There was a problem hiding this comment.
@foxnne could you pull in the changes from this PR (https://github.com/hexops/mach-objc/pull/20/files#diff-9a77edc2d43d8c912cd81d488fc5820edf004be3ecc80db7ff68c5709f2fef85R1914) into yours as well?
I think those will help you - and I meant to merge it before we got conflicts here. My bad 😀
There was a problem hiding this comment.
Thank you, I'll get those pulled in as well. Is it okay if I continue adding to this PR until more significant progress has been made? With this stuff I wasn't sure how targeted you wanted the PR's. I guess I could leave this one at just adding in title control and start another for resizing etc. Or you could just merge the other and I can just restart over the top of that?
There was a problem hiding this comment.
Sure, though it'd be great to start merging things to avoid more conflicts :) I like to merge things quickly when possible as long as it's an improvement over the current status quo
There was a problem hiding this comment.
Okay, I added the missing NSWindow methods from the referenced PR, and also added the necessary code to get the NSWindowDelegate method windowWillResize:toSize callback working. Please let me know of any changes you'd like me to make, not sure if you want to merge this before I add additional methods.
foxnne
changed the title
…te methods, and proof of concept `windowWillResize:ToSize` callback
For now this draft PR just adds the functions necessary to get the window title showing and updating. I plan on continuing to add additional functions as needed to improve windowing on macOS.This PR currently adds additional methods to
generator.zigto allow implementation in this companion PR