perf(external_link): optimized regexp #4440

SukkaW · 2020-07-25T08:38:38Z

What does it do?

How to test

git clone -b external-link-regexp-perf https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

Add test cases for the changes.
Passed the CI test.

coveralls · 2020-07-25T08:40:04Z

Coverage increased (+0.004%) to 98.237% when pulling 5aecc10 on SukkaW:external-link-regexp-perf into 9076422 on hexojs:master.

SukkaW · 2020-07-25T08:58:09Z

lib/plugins/filter/after_post_render/external_link.js

+const rATag = /<a(?:\s+?|\s+?[^<>]+\s+?)?href=["']([^<>"']+)["'][^<>]*>/gi;
+const rTargetAttr = /target=/i;
+const rRelAttr = /rel=/i;
+const rRelStrAttr = /rel=["']([^<>"']*)["']/i;


Optimized rATag results in 20% less steps during regex matching

Cache regexp when hexo is loaded

perf(externalink): improved regexp

5aecc10

SukkaW requested a review from a team July 25, 2020 08:38

SukkaW mentioned this pull request Jul 25, 2020

release: 5.0.0 #4423

Merged

22 tasks

SukkaW commented Jul 25, 2020

View reviewed changes

curbengh approved these changes Jul 25, 2020

View reviewed changes

SukkaW merged commit a29d609 into hexojs:master Jul 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(external_link): optimized regexp #4440

perf(external_link): optimized regexp #4440

SukkaW commented Jul 25, 2020

coveralls commented Jul 25, 2020

SukkaW Jul 25, 2020

perf(external_link): optimized regexp #4440

perf(external_link): optimized regexp #4440

Conversation

SukkaW commented Jul 25, 2020

What does it do?

How to test

Screenshots

Pull request tasks

coveralls commented Jul 25, 2020

SukkaW Jul 25, 2020

Choose a reason for hiding this comment