Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(benchmark): optimize for local & render post support #4428

Merged
merged 2 commits into from
Jul 23, 2020
Merged

test(benchmark): optimize for local & render post support #4428

merged 2 commits into from
Jul 23, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Jul 19, 2020 •
edited
Loading

What does it do?

  • Speed up local benchmark.
    • When testDir exists, benchmark.js won't setup dummy blog again.
  • Add hook for Rendering Post

How to test

git clone -b faster-local-benchmark https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested review from segayuu, himself65, curbengh and a team July 19, 2020 05:36
@SukkaW SukkaW force-pushed the faster-local-benchmark branch from 4de09f3 to cb8201a Compare July 19, 2020 05:38
@coveralls
Copy link

coveralls commented Jul 19, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 98.238% when pulling 90889a1 on SukkaW:faster-local-benchmark into 97cb698 on hexojs:master.

@SukkaW SukkaW marked this pull request as draft July 19, 2020 13:07
@SukkaW SukkaW marked this pull request as ready for review July 19, 2020 13:14
@SukkaW SukkaW changed the title test(benchmark): speed up local benchmark test(benchmark): optimize for local & render post support Jul 19, 2020
SukkaW
SukkaW commented Jul 20, 2020
View reviewed changes
test/benchmark.js
@@ -104,6 +107,9 @@ async function init() {
resolve(testDir, 'node_modules', 'hexo'),
resolve(__dirname, '..')
]);

await rmdir(resolve(testDir, 'node_modules', 'hexo-cli'));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove hexo-cli for mklink hexo-cli on win32 platform

@SukkaW SukkaW merged commit 3a56d29 into hexojs:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@segayuu segayuu Awaiting requested review from segayuu

@curbengh curbengh Awaiting requested review from curbengh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SukkaW @coveralls @himself65