Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tag): show source of the error & beautify #4420

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Jul 15, 2020

What does it do?

#3859 #4109 #1771

  • Show the source file that contains error
    source is available as a property of options that passed to tag.render.
  • Beautify the Error
    • The source of error will be colored in magenta while the error type will be in red.

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

image

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested review from stevenjoezhang, curbengh and a team July 15, 2020 14:49
@coveralls
Copy link

coveralls commented Jul 15, 2020

Coverage Status

Coverage increased (+0.0005%) to 98.238% when pulling 821ef12 on SukkaW:tag-error-source into 064daa4 on hexojs:master.

@SukkaW SukkaW requested a review from seaoak July 15, 2020 14:59
@SukkaW SukkaW mentioned this pull request Jul 16, 2020
22 tasks
lib/extend/tag.js Outdated Show resolved Hide resolved
lib/extend/tag.js Outdated Show resolved Hide resolved
@SukkaW SukkaW force-pushed the tag-error-source branch from 9c8db74 to 821ef12 Compare July 17, 2020 14:35
@SukkaW SukkaW requested a review from dailyrandomphoto July 17, 2020 14:35
@SukkaW SukkaW merged commit a34a7e2 into hexojs:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants