Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually allow plugins to be stored as devDependencies #2680

Merged
merged 2 commits into from
Oct 20, 2017

Conversation

jd-carroll
Copy link

Plugins should be sourced from all available options, meaning both dependencies and devDependencies. In the current implementation (#2558), plugins are only loaded from devDependencies if there are no dependencies.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0007%) to 97.154% when pulling acfe620 on jd-carroll:master into 6c0fbd0 on hexojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0007%) to 97.154% when pulling acfe620 on jd-carroll:master into 6c0fbd0 on hexojs:master.

@NoahDragon NoahDragon added the enhancement New feature or request label Sep 18, 2017
@jd-carroll
Copy link
Author

Any chance this could be merged? I view this more as a bug than an enhancement...

@JLHwung JLHwung merged commit 5f7f4e3 into hexojs:master Oct 20, 2017
@JLHwung
Copy link
Collaborator

JLHwung commented Oct 20, 2017

Thank you so much for you contribution. Hexo can't be rock without contributors like you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants