-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow open_graph generates meta tag "keywords" by page.keywords, page.tags or config.keywords #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restran
changed the title
Allow open_graph generates meta tag "keywords" by page.keywords, page.tags or theme.keywords
Allow open_graph generates meta tag "keywords" by page.keywords, page.tags or config.keywords
Apr 25, 2017
NoahDragon
requested changes
Apr 25, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could please add the test cases?
@NoahDragon OK, i will do it later. |
@restran Thank you. 👍 |
@NoahDragon Please review. |
NoahDragon
approved these changes
Apr 26, 2017
LGTM. Thanks for the contribution. |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The open_graph generates HTML meta tag "keywords" only according to page.tags. Allow HTML meta tag "keywords" generated in order of page.keywords, page.tags and config.keywords could be more flexible.
If no keywords or tags specified in page, keywords in _config.js will be used.
I also check the type of keywords to support string or array.
I also add escapeHTML to the content of meta tag in consider of avoiding XSS issue. These characters ' "
<> & / in content of meta tag should be escaped.