refactor: update isExternalLink

hexojs · Nov 6, 2019 · 60acb95 · 60acb95
1 parent 878cf1b
commit 60acb95
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/plugins/filter/after_post_render/external_link.js b/lib/plugins/filter/after_post_render/external_link.js
@@ -14,12 +14,12 @@ const isExternal = (url, config) => {
   const exclude = Array.isArray(config.external_link.exclude) ? config.external_link.exclude
     : [config.external_link.exclude];
   const data = urlObj(url);
-  const host = data.hostname;
-  const sitehost = typeof urlObj(config.url) === 'object' ? urlObj(config.url).hostname : config.url;
+  const sitehost = urlObj(config.url).hostname || config.url;
 
   if (!sitehost || typeof data === 'string') return false;
   if (data.origin === 'null') return false;
 
+  const host = data.hostname;
   if (exclude && exclude.length) {
     for (const i of exclude) {
       if (host === i) return false;

diff --git a/lib/plugins/filter/after_render/external_link.js b/lib/plugins/filter/after_render/external_link.js
@@ -20,12 +20,12 @@ const isExternal = (url, config) => {
   const exclude = Array.isArray(config.external_link.exclude) ? config.external_link.exclude
     : [config.external_link.exclude];
   const data = urlObj(url);
-  const host = data.hostname;
-  const sitehost = typeof urlObj(config.url) === 'object' ? urlObj(config.url).hostname : config.url;
+  const sitehost = urlObj(config.url).hostname || config.url;
 
   if (!sitehost || typeof data === 'string') return false;
   if (data.origin === 'null') return false;
 
+  const host = data.hostname;
   if (exclude && exclude.length) {
     for (const i of exclude) {
       if (host === i) return false;