refactor(external_link): relpace test() with includes()

hexojs · Nov 6, 2019 · 216f653 · 216f653
1 parent 6d9ed7a
commit 216f653
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/plugins/filter/after_post_render/external_link.js b/lib/plugins/filter/after_post_render/external_link.js
@@ -48,9 +48,9 @@ function externalLinkFilter(data) {
     : [config.external_link.exclude];
 
   data.content = data.content.replace(/<a.*?(href=['"](.*?)['"]).*?>/gi, (str, hrefStr, href) => {
-    if (/target=/gi.test(str) || !isExternal(href, config)) return str;
+    if (str.includes('target=') || !isExternal(href, config)) return str;
 
-    if (/rel=/gi.test(str)) {
+    if (str.includes('rel=')) {
       str = str.replace(/rel="(.*?)"/gi, (relStr, rel) => {
         if (!rel.includes('noopenner')) relStr = relStr.replace(rel, `${rel} noopener`);
         return relStr;

diff --git a/lib/plugins/filter/after_render/external_link.js b/lib/plugins/filter/after_render/external_link.js
@@ -54,9 +54,9 @@ function externalLinkFilter(data) {
     : [config.external_link.exclude];
 
   data = data.replace(/<a.*?(href=['"](.*?)['"]).*?>/gi, (str, hrefStr, href) => {
-    if (/target=/gi.test(str) || !isExternal(href, config)) return str;
+    if (str.includes('target=') || !isExternal(href, config)) return str;
 
-    if (/rel=/gi.test(str)) {
+    if (str.includes('rel=')) {
       str = str.replace(/rel="(.*?)"/gi, (relStr, rel) => {
         if (!rel.includes('noopenner')) relStr = relStr.replace(rel, `${rel} noopener`);
         return relStr;