Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Deprecation from kelektiv/node-uuid#240 #88

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Remove Deprecation from kelektiv/node-uuid#240 #88

merged 1 commit into from
Jun 4, 2019

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Jun 4, 2019

Deprecation warning from uuidjs/uuid#240

@segayuu segayuu requested a review from a team June 4, 2019 01:47
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.286% when pulling 72a5c2e on segayuu:Refactor-test into 51721d5 on hexojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.286% when pulling 72a5c2e on segayuu:Refactor-test into 51721d5 on hexojs:master.

@segayuu
Copy link
Contributor Author

segayuu commented Jun 4, 2019

The AppVeyor error is a communication error with git, not the test itself.

yoshinorin
yoshinorin approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yoshinorin yoshinorin merged commit 518fe81 into hexojs:master Jun 4, 2019
@yoshinorin yoshinorin added this to the v0.4.0 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@segayuu @coveralls @yoshinorin