Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(es2015) #97

Merged
merged 5 commits into from
May 25, 2019
Merged

Refactor(es2015) #97

merged 5 commits into from
May 25, 2019
+26 −36

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented May 21, 2019

No description provided.

@segayuu segayuu requested review from JLHwung, tcrowe, tomap, yoshinorin and a team May 21, 2019 06:46
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.5%) to 83.721% when pulling 8b72da7 on segayuu:Refactor-ex2015 into 944fa64 on hexojs:master.

@yoshinorin
Copy link
Member

@segayuu
Would you give me a time?
I'm not familiar with Regex. So I can't judge this change.

@segayuu segayuu requested a review from yoshinorin May 25, 2019 07:38
yoshinorin
yoshinorin approved these changes May 25, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yoshinorin yoshinorin merged commit 27eb9c1 into hexojs:master May 25, 2019
@segayuu segayuu deleted the Refactor-ex2015 branch May 26, 2019 00:31
@yoshinorin yoshinorin added this to the v2.0.0 milestone Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

@JLHwung JLHwung Awaiting requested review from JLHwung

@tcrowe tcrowe Awaiting requested review from tcrowe

@tomap tomap Awaiting requested review from tomap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@segayuu @coveralls @yoshinorin