Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new option figcaption #264

Merged
merged 3 commits into from
Jul 22, 2023
Merged

feat: new option figcaption #264

merged 3 commits into from
Jul 22, 2023

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Jul 21, 2023

Append figcaption element after each image.
This feature is supported by other renderers, e.g. hexo-renderer-pandoc.
https://pandoc.org/MANUAL.html#extension-implicit_figures

@coveralls
Copy link

coveralls commented Jul 21, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling 13f1ad5 on figcaption into 906eae3 on master.

Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test cases are not updated.

@haiweichai
Copy link

@stevenjoezhang 您好,在 _config.yml 中添加 figcaption: true 可以正确渲染 image caption。

但是原本宽度100%的图片在 image caption 正确渲染时会略微缩小。请问该如何屏蔽图片尺寸缩小的功能呢?

我注意到目前 marker 只能使用 markdown 语法书写才能正确渲染 image caption,而 markdown 语法下似乎没法很简单的调节宽度。这确实带来了一点排版上不便。非常感谢!

@stevenjoezhang
Copy link
Member Author

@haiweichai 你有具体的例子吗?我不确定略微缩小是为何产生的,image caption是附加上去的元素,理应不会影响图片大小。你也可以尝试通过自定义的CSS进行调整。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants