fix: encode URL by default #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curbengh
force-pushed
the
sanitize-url
branch
from
0625377 to
9d1754d
Compare
curbengh
force-pushed
the
sanitize-url
branch
from
9d1754d to
538252e
Compare
|
Ready for review. I intend to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url should always be encoded. replace part of
sanitizeUrlfunction with encodeURL.encodeURL is added in hexo-util 1.1.0.
Note the hostname is not encoded (into percent-encoding) to handle IDN properly.
Just noticed
title=""andalt=""values (e.g.[foo](http://example.com "<bar>")and) are automatically escaped by marked so escapeHTML() is not needed.