fix: handle invalid URL

hexojs · Aug 31, 2020 · 46ea0d6 · 46ea0d6
1 parent 0abcf7d
commit 46ea0d6
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/lib/renderer.js b/lib/renderer.js
@@ -51,7 +51,16 @@ class Renderer extends MarkedRenderer {
       }
     }
 
-    let out = `<a href="${encodeURL(href)}"`;
+    let out = '<a href="';
+
+    try {
+      out += encodeURL(href);
+    } catch (e) {
+      out += href;
+    }
+
+    out += '"';
+
     if (title) {
       out += ` title="${title}"`;
     }

diff --git a/test/index.js b/test/index.js
@@ -42,7 +42,7 @@ describe('Marked renderer', () => {
 
     result.should.eql([
       '<h1 id="Hello-world"><a href="#Hello-world" class="headerlink" title="Hello world"></a>Hello world</h1>',
-      '<pre><code>' + escapeHTML(code) + '</code></pre>\n',
+      '<pre><code>' + escapeHTML(code) + '</code></pre>',
       '<h2 id="Hello-world-1"><a href="#Hello-world-1" class="headerlink" title="Hello world"></a>Hello world</h2>',
       '<p>hello</p>'
     ].join('') + '\n');
@@ -150,6 +150,16 @@ describe('Marked renderer', () => {
     ].join('\n'));
   });
 
+  it('shouldn\'t encode when not a valid URL', () => {
+    const url = 'http://localhost:4000你好';
+
+    const body = `[foo](${url})`;
+
+    const result = r({text: body});
+
+    result.should.eql(`<p><a href="${url}">foo</a></p>\n`);
+  });
+
   describe('autolink option tests', () => {
     const hexo = new Hexo(__dirname, {silent: true});
     const ctx = Object.assign(hexo, {