fix: handle invalid URL (#163)

hexojs · Sep 1, 2020 · 3b85cf0 · 3b85cf0
1 parent 0abcf7d
commit 3b85cf0
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/renderer.js b/lib/renderer.js
@@ -51,7 +51,16 @@ class Renderer extends MarkedRenderer {
       }
     }
 
-    let out = `<a href="${encodeURL(href)}"`;
+    let out = '<a href="';
+
+    try {
+      out += encodeURL(href);
+    } catch (e) {
+      out += href;
+    }
+
+    out += '"';
+
     if (title) {
       out += ` title="${title}"`;
     }

diff --git a/test/index.js b/test/index.js
@@ -150,6 +150,16 @@ describe('Marked renderer', () => {
     ].join('\n'));
   });
 
+  it('shouldn\'t encode when not a valid URL', () => {
+    const url = 'http://localhost:4000你好';
+
+    const body = `[foo](${url})`;
+
+    const result = r({text: body});
+
+    result.should.eql(`<p><a href="${url}">foo</a></p>\n`);
+  });
+
   describe('autolink option tests', () => {
     const hexo = new Hexo(__dirname, {silent: true});
     const ctx = Object.assign(hexo, {