Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use Object.assign & Map #36

Merged
merged 1 commit into from
Aug 6, 2020
Merged

refactor: use Object.assign & Map #36

merged 1 commit into from
Aug 6, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Aug 5, 2020

  • Use Object.assign for default option
  • Use Map for cache

@SukkaW SukkaW requested a review from a team August 5, 2020 14:25
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7ccd132 on SukkaW:refactor into 0045d3e on hexojs:master.

jiangtj
jiangtj approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@jiangtj jiangtj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SukkaW SukkaW merged commit a9f1958 into hexojs:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangtj jiangtj jiangtj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SukkaW @coveralls @jiangtj