Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use gravatar from hexo-util #94

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Sep 8, 2019

gravatar() is available on hexo-util 1.2.0.

@coveralls
Copy link

coveralls commented Sep 8, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling d7933aa on curbengh:gravatar into d66f225 on hexojs:master.

@tomap
Copy link
Contributor

tomap commented Sep 8, 2019

I believe we should move the gravatar dependency to hexo-util and not introduce a dependency with hexo in a plugin

@curbengh
Copy link
Contributor Author

curbengh commented Sep 8, 2019

In addition to gravatar, I want to move url_for() and relative_url() to hexo-util. Though we might end up moving all helpers to hexo-util... 😅 (PS: I don't mind moving all helpers)

@tomap
Copy link
Contributor

tomap commented Sep 11, 2019

Let's start with gravatar :)

hexojs/hexo-util#81

@curbengh curbengh changed the title chore(deps): add hexo WIP chore(deps): add hexo Sep 11, 2019
@curbengh curbengh changed the title WIP chore(deps): add hexo refactor: use gravatar from hexo-util Sep 24, 2019
@curbengh
Copy link
Contributor Author

Let's start with gravatar :)

hexojs/hexo-util#81

refactored

@curbengh curbengh merged commit af62b8e into hexojs:master Sep 24, 2019
@curbengh curbengh deleted the gravatar branch September 24, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants