Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/ci: drop Node.js 12 #124

Merged
merged 3 commits into from
Jul 28, 2023
Merged

chore/ci: drop Node.js 12 #124

merged 3 commits into from
Jul 28, 2023

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Jul 28, 2023

The PR closes #116 (along with #120).

Breaking change: Drop Node.js 12 supports.

The PR also replaces nunjucks with ECMAScript TemplateLiteral.

@SukkaW SukkaW requested review from stevenjoezhang and tomap July 28, 2023 15:32
@coveralls
Copy link

coveralls commented Jul 28, 2023

Coverage Status

coverage: 76.471% (-1.3%) from 77.778% when pulling bb3020c on SukkaW:drop-node-12 into a59ba9e on hexojs:master.

@stevenjoezhang
Copy link
Member

Is it necessary to submit the package-lock.json file?

@SukkaW
Copy link
Member Author

SukkaW commented Jul 28, 2023

Is it necessary to submit the package-lock.json file?

Hmmm, no. I will remove it.

@SukkaW SukkaW merged commit 7290ea4 into hexojs:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please fix hexo-deployer-heroku
3 participants