Case-insensitive comparison of IPv6 addresses #468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our API converts upper-case IPv6 addresses to lower-case. This in turn
leads to a mismatch between what is stored in the Terraform state and
what our API returns. As a result Terraform tries to update a rule,
which does not need updating.
The solution is to convert any IP addresses to lower-case before
Terraform saves them to the state. This can be easily achieved using the
StateFunc field of schema.Schema. However, when the field is used within
a schema element of schema.TypeSet it creates an additional invalid
value. This to be a known bug in Terraform:
hashicorp/terraform-plugin-sdk#160
For our case we can get by with filtering the invalid entry from the
firewall rules before sending any requests to the API.