feat: support for Robot servers #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
commented
Nov 13, 2023
jooola
reviewed
Nov 13, 2023
apricote
force-pushed
the
support-robot-servers
branch
from
dee5e96
to
2af7752
Compare
|
Implemented all review feedback. Diff here: https://github.com/hetznercloud/hcloud-cloud-controller-manager/compare/dee5e961e27d41f309292c45b3c011ef107c8a4b..2af7752e1d6a85a4062584d5e57aedc70cad4f7b |
apricote
force-pushed
the
support-robot-servers
branch
from
2af7752
to
3249103
Compare
|
Tests failed before as I forgot to add the |
jooola
reviewed
Nov 15, 2023
apricote
force-pushed
the
support-robot-servers
branch
from
3249103
to
3314f05
Compare
apricote
force-pushed
the
support-robot-servers
branch
from
3314f05
to
ac907c4
Compare
jooola
approved these changes
Nov 17, 2023
|
Waiting on #564 for a final rebase & CI fixing run. |
apricote
force-pushed
the
support-robot-servers
branch
from
ac907c4
to
2576cd4
Compare
apricote
force-pushed
the
support-robot-servers
branch
from
2576cd4
to
7206ef7
Compare
apricote
force-pushed
the
support-robot-servers
branch
from
7206ef7
to
6ef314e
Compare
apricote
force-pushed
the
support-robot-servers
branch
from
6ef314e
to
5ef4ecc
Compare
jooola
reviewed
Nov 21, 2023
Co-authored-by: janiskemper <[email protected]> Co-authored-by: Mawe Sprenger <[email protected]> Co-authored-by: Thomas Guettler <[email protected]> Co-authored-by: Anurag <[email protected]> Co-authored-by: batistein <[email protected]>
apricote
force-pushed
the
support-robot-servers
branch
from
5ef4ecc
to
d6ed31d
Compare
jooola
reviewed
Nov 21, 2023
apricote
force-pushed
the
support-robot-servers
branch
from
d6ed31d
to
1208c15
Compare
apricote
force-pushed
the
support-robot-servers
branch
from
1208c15
to
9d79076
Compare
This commit adds setup code to initialize & use Robot servers in e2e tests. It uses installimage with autosetup to prepare the server and then uses k3sup similar to our existing setup to join the server into the existing kubernetes cluster. Right now it only supports joining Robot servers as worker nodes, not for the control-plane. Also, it only supports non-Private Network setups.
apricote
force-pushed
the
support-robot-servers
branch
from
9d79076
to
c6ca2ae
Compare
apricote
requested a deployment
to
e2e-robot
GitHub Actions
Abandoned
This was referenced Nov 21, 2023
apricote
added a commit
that referenced
this pull request
Dec 1, 2023
- Add documentation for the features introduced in #561. - Cleans up some other documentation fragments that have become outdated with time. Closes #528 Co-authored-by: Jonas L. <[email protected]>
apricote
pushed a commit
that referenced
this pull request
Dec 1, 2023
🤖 I have created a release *beep* *boop* --- ## [1.19.0-rc.0](v1.18.0...v1.19.0-rc.0) (2023-12-01) ### Features * **chart:** add daemonset and node selector ([#537](#537)) ([a94384f](a94384f)) * **config:** stricter validation for settings `HCLOUD_LOAD_BALANCERS_ENABLED`, `HCLOUD_METRICS_ENABLED` & `HCLOUD_NETWORK_ROUTES_ENABLED` ([#546](#546)) ([335a2c9](335a2c9)) * **helm:** remove "v" prefix from chart version ([#565](#565)) ([f11aa0d](f11aa0d)), closes [#529](#529) * **load-balancer:** handle planned targets exceedings max targets ([#570](#570)) ([8bb131f](8bb131f)) * remove unused variable NODE_NAME ([#545](#545)) ([a659408](a659408)) * **robot:** handle ratelimiting with constant backoff ([#572](#572)) ([2ddc201](2ddc201)) * support for Robot servers ([#561](#561)) ([65dea11](65dea11)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
apricote
added a commit
that referenced
this pull request
Dec 7, 2023
## [1.19.0](v1.18.0...v1.19.0) (2023-12-07) ### Features * **chart:** add daemonset and node selector ([#537](#537)) ([a94384f](a94384f)) * **config:** stricter validation for settings `HCLOUD_LOAD_BALANCERS_ENABLED`, `HCLOUD_METRICS_ENABLED` & `HCLOUD_NETWORK_ROUTES_ENABLED` ([#546](#546)) ([335a2c9](335a2c9)) * **helm:** remove "v" prefix from chart version ([#565](#565)) ([f11aa0d](f11aa0d)), closes [#529](#529) * **load-balancer:** handle planned targets exceedings max targets ([#570](#570)) ([8bb131f](8bb131f)) * remove unused variable NODE_NAME ([#545](#545)) ([a659408](a659408)) * **robot:** handle ratelimiting with constant backoff ([#572](#572)) ([2ddc201](2ddc201)) * support for Robot servers ([#561](#561)) ([65dea11](65dea11))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the Fork by Syself and the Design Doc in #523 (comment).
This ports most of the features the Fork while refactoring them to match our coding style and the improvements I made in preparation for this.
I recommend reviewing by commit.
Docs are still being worked on and will be added in a follow up PR before making a release.
Closes #525 #526 #527