Skip to content

Commit

Permalink
feat(helm): remove "v" prefix from chart version (#565)
Browse files Browse the repository at this point in the history
This makes sure that the chart version is fully semver compliant, as Helm expects.

Fixes #529

Signed-off-by: kranurag7 <[email protected]>
Co-authored-by: Julian Tölle <[email protected]>
Release-As: 1.19.0-rc.0
  • Loading branch information
kranurag7 and apricote authored Dec 1, 2023
1 parent 956c2ef commit f11aa0d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .goreleaser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
before:
hooks:
- go mod tidy
- ./scripts/release-generate-deployment-yamls.sh {{ if not .IsSnapshot }}v{{ end }}{{ .Version }}
- ./scripts/release-generate-deployment-yamls.sh {{ .Version }}

builds:
- id: hcloud-cloud-controller-manager
Expand Down Expand Up @@ -59,6 +59,6 @@ publishers:
ids: [""]
checksum: true

cmd: ./scripts/publish-helm-chart.sh hcloud-cloud-controller-manager-{{ if not .IsSnapshot }}v{{ end }}{{ .Version }}.tgz
cmd: ./scripts/publish-helm-chart.sh hcloud-cloud-controller-manager-{{ .Version }}.tgz
env:
- CHART_REPO_REMOTE={{ .Env.CHART_REPO_REMOTE }}
2 changes: 1 addition & 1 deletion chart/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: v2
name: hcloud-cloud-controller-manager
type: application
version: v1.18.0 # x-release-please-version
version: 1.18.0 # x-release-please-version
2 changes: 1 addition & 1 deletion chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ env:

image:
repository: hetznercloud/hcloud-cloud-controller-manager
tag: '{{ $.Chart.Version }}'
tag: 'v{{ $.Chart.Version }}'

monitoring:
# When enabled, the hccm Pod will serve metrics on port :8233
Expand Down

0 comments on commit f11aa0d

Please sign in to comment.