Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move tools to module to prevent bloating the root module #901

Merged

Conversation

jooola
Copy link
Member

@jooola jooola commented Nov 8, 2024

This dedicated module is used to prevent bloating the root Go module.

The mock package is still in the root module, as it is not an external tool, but is part of the code.

@jooola jooola requested a review from a team as a code owner November 8, 2024 09:44
@jooola jooola force-pushed the chore--move-tools-to-module-to-prevent-bloating-the-root-module branch from 4a27cb2 to 3a50797 Compare November 8, 2024 09:45
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.23%. Comparing base (c16af7f) to head (14e5a40).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #901   +/-   ##
=======================================
  Coverage   69.23%   69.23%           
=======================================
  Files         244      244           
  Lines       10640    10640           
=======================================
  Hits         7367     7367           
  Misses       2605     2605           
  Partials      668      668           
Flag Coverage Δ
e2e 42.80% <ø> (ø)
unit 63.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola force-pushed the chore--move-tools-to-module-to-prevent-bloating-the-root-module branch from 3a50797 to 4b35d50 Compare November 8, 2024 09:47
@jooola jooola force-pushed the chore--move-tools-to-module-to-prevent-bloating-the-root-module branch from 4b35d50 to 14e5a40 Compare November 8, 2024 09:57
@jooola jooola requested a review from phm07 November 8, 2024 09:58
@jooola jooola merged commit 2bed829 into main Nov 8, 2024
6 checks passed
@jooola jooola deleted the chore--move-tools-to-module-to-prevent-bloating-the-root-module branch November 8, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants