feat(certificate): allow retrying managed certificate issuance #847
Conversation
|
It is debatable whether |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 61.43% 61.42% -0.01%
==========================================
Files 237 238 +1
Lines 8494 8516 +22
==========================================
+ Hits 5218 5231 +13
- Misses 2567 2572 +5
- Partials 709 713 +4 ☔ View full report in Codecov by Sentry. |
| var RetryCmd = base.Cmd{ | ||
| BaseCobraCommand: func(client hcapi2.Client) *cobra.Command { | ||
| return &cobra.Command{ | ||
| Use: "retry <certificate>", |
There was a problem hiding this comment.
It is debatable whether retry or retry-issuance is a better name for the command. retry-issuance is more precise, but also very cumbersome to use. Although it probably won't be used much anyway, since this feature was missing for 3 years and nobody noticed.
Its called retry in the API and RetryIssuance in Go, so we are not consistent any way.
I lean towards retry to be consistent with the API.
🤖 I have created a release *beep* *boop* --- ## [1.47.0](v1.46.0...v1.47.0) (2024-08-30) ### Features * allow deleting rDNS entries ([#839](#839)) ([129f51d](129f51d)), closes [#814](#814) * **certificate:** allow retrying managed certificate issuance ([#847](#847)) ([0223f7d](0223f7d)) * improve datacenter describe server types readability ([#854](#854)) ([fc0002c](fc0002c)), closes [#852](#852) ### Bug Fixes * `quiet` option sometimes only working as a flag ([#846](#846)) ([f7c9ac6](f7c9ac6)) * **image:** only accept numerical ids for update, delete, label ([#844](#844)) ([7355571](7355571)) * **load-balancer:** show message if none of --server, --label-selector or --ip is set ([#849](#849)) ([2df45e0](2df45e0)) * **primary-ip:** change protection commands do not allow protection levels ([#851](#851)) ([697a87a](697a87a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Somehow this API call didn't have a corresponding command in the CLI, so this PR adds it.