-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): add default-ssh-keys option #759
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
==========================================
- Coverage 59.32% 59.31% -0.02%
==========================================
Files 203 203
Lines 7460 7462 +2
==========================================
Hits 4426 4426
- Misses 2400 2401 +1
- Partials 634 635 +1 ☔ View full report in Codecov by Sentry. |
phm07
force-pushed
the
switch-toml-lib
branch
2 times, most recently
from
May 29, 2024 13:10
b3275ea
to
628faa0
Compare
phm07
force-pushed
the
switch-toml-lib
branch
2 times, most recently
from
June 6, 2024 14:54
3c886b8
to
aec51fb
Compare
apricote
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
phm07
pushed a commit
that referenced
this pull request
Jun 20, 2024
🤖 I have created a release *beep* *boop* --- ## [1.44.0](v1.43.1...v1.44.0) (2024-06-20) ### Features * delete multiple resources in parallel ([#761](#761)) ([f2fb321](f2fb321)) * improve toml formatting ([#758](#758)) ([eacb7dd](eacb7dd)) * **load-balancer:** allow specifying health check options in add-service ([#743](#743)) ([2cd08b2](2cd08b2)), closes [#742](#742) * new action waiting progress ([#749](#749)) ([9e30f3f](9e30f3f)) * new configuration system, config subcommand ([#736](#736)) ([d1c6678](d1c6678)) * **server-type:** add deprecated column to list command ([#780](#780)) ([906f864](906f864)) * **server:** add default-ssh-keys option ([#759](#759)) ([9b34d26](9b34d26)) ### Bug Fixes * **firewall:** 'create --rules-file' not working with outbound rules ([#752](#752)) ([2f2be32](2f2be32)), closes [#750](#750) * network list server count format ([#783](#783)) ([f69d261](f69d261)) * track progress if the terminal width allows it ([#768](#768)) ([069fffe](069fffe)), closes [#767](#767) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
default-ssh-keys
option which allows you to define a list of SSH keys to be used as defaults for thehcloud server create
command.