Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add default-ssh-keys option #759

Merged
merged 1 commit into from
Jun 6, 2024
Merged

feat(server): add default-ssh-keys option #759

merged 1 commit into from
Jun 6, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented May 21, 2024

This PR adds the default-ssh-keys option which allows you to define a list of SSH keys to be used as defaults for the hcloud server create command.

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.31%. Comparing base (eacb7dd) to head (46273e2).

Files Patch % Lines
internal/cmd/server/create.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
- Coverage   59.32%   59.31%   -0.02%     
==========================================
  Files         203      203              
  Lines        7460     7462       +2     
==========================================
  Hits         4426     4426              
- Misses       2400     2401       +1     
- Partials      634      635       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 force-pushed the switch-toml-lib branch 2 times, most recently from b3275ea to 628faa0 Compare May 29, 2024 13:10
@phm07 phm07 force-pushed the switch-toml-lib branch 2 times, most recently from 3c886b8 to aec51fb Compare June 6, 2024 14:54
Base automatically changed from switch-toml-lib to main June 6, 2024 15:01
@phm07 phm07 marked this pull request as ready for review June 6, 2024 15:06
@phm07 phm07 requested a review from a team as a code owner June 6, 2024 15:06
Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@phm07 phm07 merged commit 9b34d26 into main Jun 6, 2024
5 checks passed
@phm07 phm07 deleted the default-ssh-keys branch June 6, 2024 15:12
phm07 pushed a commit that referenced this pull request Jun 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.44.0](v1.43.1...v1.44.0)
(2024-06-20)


### Features

* delete multiple resources in parallel
([#761](#761))
([f2fb321](f2fb321))
* improve toml formatting
([#758](#758))
([eacb7dd](eacb7dd))
* **load-balancer:** allow specifying health check options in
add-service ([#743](#743))
([2cd08b2](2cd08b2)),
closes [#742](#742)
* new action waiting progress
([#749](#749))
([9e30f3f](9e30f3f))
* new configuration system, config subcommand
([#736](#736))
([d1c6678](d1c6678))
* **server-type:** add deprecated column to list command
([#780](#780))
([906f864](906f864))
* **server:** add default-ssh-keys option
([#759](#759))
([9b34d26](9b34d26))


### Bug Fixes

* **firewall:** 'create --rules-file' not working with outbound rules
([#752](#752))
([2f2be32](2f2be32)),
closes [#750](#750)
* network list server count format
([#783](#783))
([f69d261](f69d261))
* track progress if the terminal width allows it
([#768](#768))
([069fffe](069fffe)),
closes [#767](#767)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants