Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow formatting a volume without automounting it #530

Merged
merged 2 commits into from
Aug 17, 2023
Merged

feat: allow formatting a volume without automounting it #530

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d90f553
Allow formatting a volume without automounting it
marvinruder Aug 15, 2023
57748b7
Document supported volume formats
marvinruder Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions internal/cmd/volume/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ var CreateCommand = base.Cmd{
cmd.MarkFlagRequired("size")

cmd.Flags().Bool("automount", false, "Automount volume after attach (server must be provided)")
cmd.Flags().String("format", "", "Format volume after creation (automount must be enabled)")

cmd.Flags().String("format", "", "Format volume after creation (ext4 or xfs)")
cmd.RegisterFlagCompletionFunc("format", cmpl.SuggestCandidates("ext4", "xfs"))

cmd.Flags().StringToString("label", nil, "User-defined labels ('key=value') (can be specified multiple times)")

Expand Down Expand Up @@ -76,9 +78,9 @@ var CreateCommand = base.Cmd{
}
if automount {
opts.Automount = &automount
if format != "" {
opts.Format = &format
}
}
if format != "" {
opts.Format = &format
}

result, _, err := client.Volume().Create(ctx, opts)
Expand Down
Loading