Feature/open one form and clear #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update to React 16.3 - remove componentWillMount in exchange for new static lifestyle method getDerivedStateFromProps - feature implemented by lifting 'active' form state up to index where they are rendered - known issue - Warning received in console claiming that componentWillReceiveProps() is being called in Form component. - Form state is not cleared when clicking the same hand
- no other changes to last commit
hessnd
requested changes
Apr 9, 2018
| @@ -3,8 +3,26 @@ import PropTypes from 'prop-types'; | |||
| import firebase from 'lib/firebase'; | |||
|
|
|||
| class Form extends Component { | |||
| constructor() { | |||
| super(); | |||
| static getDerivedStateFromProps(nextProps, prevState) { | |||
There was a problem hiding this comment.
@bortojac I would refactor this to only have one return, I would have an object variable and then change just the hand property based on your if statement.
pages/index.js
Outdated
|
|
||
| resetFormState(activeFormName) { | ||
| // we want to update the formActive state for all hands except activeFormName | ||
| const newRegions = this.state.regions.map(obj => { |
There was a problem hiding this comment.
Same issue as above. You're ending up writing the same thing twice, want to keep the code as DRY as possible
…esetFormState() in index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a look at the warning in the console. It appears to have no material affect. We are not calling componentWillReceiveProps in the Form component, yet the warning appears. There is still a lot of work being done on these new lifecycle methods,see here, so I'm wondering if this is a bug in 16.3.
We can always revert to 16.2 or use the UNSAFE methods until they are deprecated in 17