Support through Ember 2.4 #22
Merged
+37
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -988,7 +999,8 @@ module.exports = Ember.Object.extend({ | |||
| prop[key] = val; | |||
| } | |||
| }); | |||
| return this.extend(cp)._super.call(this, prop); | |||
| this.extend(cp); | |||
| return this._super.call(this, prop); | |||
There was a problem hiding this comment.
you can no longer chain things like we were doing before
|
👍 Realize i reviewed this earlier but never 👍 it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember internals keep moving the goalposts for us with Rest Model.
The latest incarnation is an error
Ember.Object.create no longer supports defining methods that call _super. This check has existed for the past many ember versions, but is a problem in >= Ember 2.1 because of (I think) this change. I was able to get around this by refactoring theMutatingArraymixin to just be a function we can call from inside the main rest model object instead of using.applyto consume it which avoided issues polluting_super. While this works, I'm not 100% convinced that there isn't a better, more permanent solution.