Fix Invalid input causes SegFault #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmavirus24
approved these changes
Apr 27, 2020
src/pghstore/_speedups.c
Outdated
| { | ||
| char *p = strchr(s, c), *q; | ||
| char *end = s + length; | ||
| debug_print( "looging for p: s[%c, %p]\n", *s, s); |
lambacck
force-pushed
the
test-invalid-input
branch
from
8591f63 to
a47bf3d
Compare
lambacck
force-pushed
the
test-invalid-input
branch
from
6752d5a to
fd1c958
Compare
|
The last test failure I fixed makes me feel like we need way more test cases to be sure it's all working correctly. |
|
Hence #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13
Fixing the segfault also revealed problems with invalid input that didn't raise exceptions. This increases coverage for invalid input cases. This may need to have a more significant version bump associated with it since it raises ValueError more often.