Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TestContext::app_dir, only copy app_dir when preprocessor is configured #431

Merged
merged 3 commits into from
Jun 24, 2022

Conversation

Malax
Copy link
Member

@Malax Malax commented Jun 24, 2022

GitHub code search did not yield any results that showed that people are using this field.

Changelog

  • Remove TestContext::app_dir to encourage the use of TestConfig::app_dir_preprocessor.
  • Improve performance when no TestConfig::app_dir_preprocessor is configured by skipping application directory copying.

@Malax Malax force-pushed the malax/remove-app-dir-from-context branch from ced7dfb to debff59 Compare June 24, 2022 10:56
@Malax Malax changed the title Remove TestContext::app_dir Remove TestContext::app_dir, only copy app_dir when preprocessor is configured Jun 24, 2022
@Malax Malax changed the title Remove TestContext::app_dir, only copy app_dir when preprocessor is configured Remove TestContext::app_dir, only copy app_dir when preprocessor is configured Jun 24, 2022
@Malax Malax marked this pull request as ready for review June 24, 2022 10:59
@Malax Malax requested a review from a team as a code owner June 24, 2022 10:59
@Malax Malax added the faster tests Things that improve the runtime of tests label Jun 24, 2022
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

libcnb-test/src/test_runner.rs Outdated Show resolved Hide resolved
@Malax Malax merged commit 3ed215d into main Jun 24, 2022
@Malax Malax deleted the malax/remove-app-dir-from-context branch June 24, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change faster tests Things that improve the runtime of tests libcnb-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants