Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Launch::processes #418

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Add Launch::processes #418

merged 2 commits into from
Jun 21, 2022

Conversation

Malax
Copy link
Member

@Malax Malax commented Jun 20, 2022

Adds the ability to add multiple processes to a Launch. This can be useful when processes are created programatically and need to be added. This came out of #401, where I proposed the solution in this PR as an alternative: #401 (comment).

I don't think we'll merge #401, but even if we would, both the function in this PR and the FromIterator implementation from #401 can co-exist.

Minor improvements also included in this PR:

  • Add rudimentary RustDoc for Launch::process
  • Make Launch::process argument generic (Into<Process>)
  • Add rudimentary unit tests for Launch::process and Launch::processes

@Malax Malax requested a review from a team as a code owner June 20, 2022 16:25
@Malax Malax added libcnb-data documentation Improvements or additions to documentation enhancement New feature or request labels Jun 20, 2022
@Malax Malax force-pushed the malax/launch-processes-function branch from 959a15f to 20fa172 Compare June 20, 2022 16:30
@Malax Malax merged commit daeed5e into main Jun 21, 2022
@Malax Malax deleted the malax/launch-processes-function branch June 21, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request libcnb-data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants