libcnb-test: Pass --trust-builder to pack build
#409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to: - Normalise build log output in tests across environments. - Avoid having to add `pack config trusted-builders add ZZZZ` boilerplate to all of our CI configs. - Speed up test execution. See the issue description for more details. Fixes #407. GUS-W-11312254.
edmorley
added
libcnb-test
faster tests
Malax
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to:
procfile-cnbfor local vs CI), due to the untrusted-builder-only[<stage>]log output prefixes.pack config trusted-builders add ZZZZboilerplate to all of our CI configs.This should be safe to do, since:
libcnb-testdoesn't publish images or pass in credentials (one of the concerns of using an untrusted builder)libcnb-testwill have chosen/vetted their test images (so it's a bit different from the "end user experimenting with random builders they found on the internet" case)libcnb.rs-using project on your local machine you are already running a bunch of untrusted code, so you either trust the author of that buildpack or you don't.See the issue description for more details.
Fixes #407.
GUS-W-11312254.