Apply some reliability/failure UX best practices #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable Bash `pipefail` mode by setting an explicit GitHub Actions shell - Pass `--exit-status` to all `jq` invocations, so it actually exits non-zero on empty input See: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell https://jqlang.github.io/jq/manual/#invoking-jq
edmorley
force-pushed
the
edmorley/reliability-best-practices
branch
from
6c0f64f to
9e6fc89
Compare
Malax
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipefailmode by setting an explicit GitHub Actions shell--exit-statusto alljqinvocations, so it actually exits non-zero on empty inputSee:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell
https://jqlang.github.io/jq/manual/#invoking-jq
GUS-W-14249448.