Pin the libcnb-cargo version to the same version as libcnb-package
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflows in this repo use libcnb in two ways: 1. As a library (specifically `libcnb-package` and `libcnb-data` 2. As a binary (`cargo libcnb package`) The version of (1) is controlled by `Cargo.toml` / `Cargo.lock` in this repo. Previously the version of (2) wasn't pinned at all, and instead the latest version would be used, meaning that version could get out of sync with that of (1). Now, the version is manually pinned to the same version as in `Cargo.toml`. Longer term this should either be replaced by deriving the version in the workflow, or at least having a CI check/lint that ensures the two are in sync. However, for the short term we want to just fix CNB releases after the 0.14.0 libcnb release, until we have time to make the necessary changes in #120.
colincasey
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflows in this repo use libcnb in two ways:
libcnb-packageandlibcnb-data)cargo libcnb package)The version of (1) is controlled by
Cargo.toml/Cargo.lockin this repo.Previously the version of (2) wasn't pinned at all, and instead the latest version would be used, meaning that version could get out of sync with that of (1).
Now, the version is manually pinned to the same version as in
Cargo.toml.Longer term this should either be replaced by deriving the version in the workflow, or at least having a CI check/lint that ensures the two are in sync.
However, for the short term we want to just fix CNB releases after the 0.14.0 libcnb release, until we have time to make the necessary changes in #120.
GUS-W-13977410.