Skip to content
Node CI Suite

Revert isNaN logic to fix bug #69

Sign in to view logs

Revert isNaN logic to fix bug

Revert isNaN logic to fix bug #69

Triggered via push September 5, 2024 20:17
@eablackeablack
pushed fe23cbb
eb/fix-isnan-bug
Status Success
Total duration 2m 23s
Billable time 2m
Artifacts –

ci.yml

on: push
Matrix: Node Tests
Fit to window
Zoom out
Zoom in

Annotations

44 warnings
Node Tests (20.x, ubuntu-24.04)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Node Tests (20.x, ubuntu-24.04): src/addon-client.ts#L3
Prefer `node:url` over `url`
Node Tests (20.x, ubuntu-24.04): src/addon-client.ts#L17
Argument 'config' should be typed with a non-any type
Node Tests (20.x, ubuntu-24.04): src/addon-client.ts#L20
'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead
Node Tests (20.x, ubuntu-24.04): src/commands/addons/admin/manifest/diff.ts#L10
Missing return type on function
Node Tests (20.x, ubuntu-24.04): src/commands/addons/admin/manifest/generate.ts#L31
Missing return type on function
Node Tests (20.x, ubuntu-24.04): src/commands/addons/admin/manifest/generate.ts#L52
Prefer `Number.isNaN()` over `isNaN()`
Node Tests (20.x, ubuntu-24.04): src/commands/addons/admin/manifest/pull.ts#L17
Missing return type on function
Node Tests (20.x, ubuntu-24.04): src/commands/addons/admin/manifest/push.ts#L15
Missing return type on function
Node Tests (20.x, ubuntu-24.04): src/commands/addons/admin/manifests.ts#L12
Missing return type on function
Node Tests (20.x, ubuntu-24.04): src/commands/addons/admin/manifests/info.ts#L18
Missing return type on function
Node Tests (16.x, ubuntu-24.04)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Node Tests (16.x, ubuntu-24.04): src/addon-client.ts#L3
Prefer `node:url` over `url`
Node Tests (16.x, ubuntu-24.04): src/addon-client.ts#L17
Argument 'config' should be typed with a non-any type
Node Tests (16.x, ubuntu-24.04): src/addon-client.ts#L20
'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead
Node Tests (16.x, ubuntu-24.04): src/commands/addons/admin/manifest/diff.ts#L10
Missing return type on function
Node Tests (16.x, ubuntu-24.04): src/commands/addons/admin/manifest/generate.ts#L31
Missing return type on function
Node Tests (16.x, ubuntu-24.04): src/commands/addons/admin/manifest/generate.ts#L52
Prefer `Number.isNaN()` over `isNaN()`
Node Tests (16.x, ubuntu-24.04): src/commands/addons/admin/manifest/pull.ts#L17
Missing return type on function
Node Tests (16.x, ubuntu-24.04): src/commands/addons/admin/manifest/push.ts#L15
Missing return type on function
Node Tests (16.x, ubuntu-24.04): src/commands/addons/admin/manifests.ts#L12
Missing return type on function
Node Tests (16.x, ubuntu-24.04): src/commands/addons/admin/manifests/info.ts#L18
Missing return type on function
Node Tests (16.x, pub-hk-ubuntu-24.04-arm-small)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Node Tests (16.x, pub-hk-ubuntu-24.04-arm-small): src/addon-client.ts#L3
Prefer `node:url` over `url`
Node Tests (16.x, pub-hk-ubuntu-24.04-arm-small): src/addon-client.ts#L17
Argument 'config' should be typed with a non-any type
Node Tests (16.x, pub-hk-ubuntu-24.04-arm-small): src/addon-client.ts#L20
'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead
Node Tests (16.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifest/diff.ts#L10
Missing return type on function
Node Tests (16.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifest/generate.ts#L31
Missing return type on function
Node Tests (16.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifest/generate.ts#L52
Prefer `Number.isNaN()` over `isNaN()`
Node Tests (16.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifest/pull.ts#L17
Missing return type on function
Node Tests (16.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifest/push.ts#L15
Missing return type on function
Node Tests (16.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifests.ts#L12
Missing return type on function
Node Tests (16.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifests/info.ts#L18
Missing return type on function
Node Tests (20.x, pub-hk-ubuntu-24.04-arm-small)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Node Tests (20.x, pub-hk-ubuntu-24.04-arm-small): src/addon-client.ts#L3
Prefer `node:url` over `url`
Node Tests (20.x, pub-hk-ubuntu-24.04-arm-small): src/addon-client.ts#L17
Argument 'config' should be typed with a non-any type
Node Tests (20.x, pub-hk-ubuntu-24.04-arm-small): src/addon-client.ts#L20
'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead
Node Tests (20.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifest/diff.ts#L10
Missing return type on function
Node Tests (20.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifest/generate.ts#L31
Missing return type on function
Node Tests (20.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifest/generate.ts#L52
Prefer `Number.isNaN()` over `isNaN()`
Node Tests (20.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifest/pull.ts#L17
Missing return type on function
Node Tests (20.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifest/push.ts#L15
Missing return type on function
Node Tests (20.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifests.ts#L12
Missing return type on function
Node Tests (20.x, pub-hk-ubuntu-24.04-arm-small): src/commands/addons/admin/manifests/info.ts#L18
Missing return type on function