Tests: Update Ruby and dependencies #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
update-ruby
branch
2 times, most recently
from
c7be79b to
bb272f2
Compare
Update from Ruby 2.7 to 3.1 and bump dependencies, given Ruby 2.7
EOLs soon. Ruby 3.1 had to be used since Hatchet doesn't yet support
Ruby 3.2.
After upgrading, a number of new Rubocop fixes are needed, to resolve eg:
```
spec/hatchet/pip_spec.rb:92:88: C: [Correctable] Style/HashSyntax: Omit the hash value.
let(:app) { Hatchet::Runner.new('spec/fixtures/requirements_editable', buildpacks: buildpacks) }
```
GUS-W-12670465.
Malax
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update from Ruby 2.7 to 3.1 and bump dependencies, given Ruby 2.7 EOLs soon. Ruby 3.1 had to be used since Hatchet doesn't yet support Ruby 3.2.
After upgrading, a number of new Rubocop fixes are needed, to resolve eg:
GUS-W-12670465.